Repository navigation
chore(example): bump MYS contract_details schema version to 5 - #1561
Merged
Merged
Conversation
Pin Malaysia to contract_details v5 in the example app and document v3-v5 in the MYS schema changelog and the version matrix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
remotecom
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example app now uses Malaysia's latest contract details form (v5). The MYS schema changelog now covers v3–v5.
Why
What changed
Toggle details
jsonSchemaVersions.ts: MYScontract_details2 → 5.schemaVersions.ts: unchanged, because it already lists MYS v1–v5.MYS.mdgains v3–v5 and the README version matrix row moves to v5. Tiger has nox-rmt-schema-changelogfor MYS, so every entry is inferred from the schema diffs (v5 is tiger's current root schema, v3–v4 are frozen snapshots).annual_gross_salary; jsf v1 engine.contract_durationcomponent (unlimited maximum); standalonecontract_duration_type/contract_end_datedefinitions removed.Screenshots
N/A
Related Resources
apps/tiger/priv/json_schemas/contract_details/snapshots/MYS/{3,4}.jsonand the currentMYS.jsonTesting
example/app in a browsernpm run schema-canary -- --country=MYS --checks=pinned,latest,submitagainst sandbox after the bump (pinned v5, latest, submit v5): all pass.🤖 Generated with Claude Code
Note
Low Risk
Documentation and example-app pinning only; no library API changes, though v5 contract-duration field restructuring matters for anyone migrating off older MYS schemas.
Overview
Pins the example onboarding flow to Malaysia contract_details v5 (was v2) so local testing matches the current backend schema.
Docs now list MYS as v5 in the country matrix and add changelog entries for v3–v5: JSON Schema Form v1 and high-salary reserve messaging (v3), extreme-salary acknowledgement when pay ≥ ~USD 1M equivalent (v4), and contract duration consolidated into the shared
contract_durationcomponent with standalonecontract_duration_type/contract_end_dateremoved (v5). Integrators upgrading to v5 should expect contract-duration payload shape changes; v3–v4 are additive and flag-gated.Reviewed by Cursor Bugbot for commit 4641c15. Bugbot is set up for automated code reviews on this repo. Configure here.